Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Core to v1.4 #878

Merged
merged 2 commits into from
Jun 8, 2024
Merged

update Core to v1.4 #878

merged 2 commits into from
Jun 8, 2024

Conversation

aspeddro
Copy link
Collaborator

@aspeddro aspeddro commented Jun 8, 2024

There remain two functions using OCamlCompact

src/vendor/Json_encode.res|9 col 24| let char = c => string(OCamlCompat.String.make(1, c))
src/vendor/Json_decode.res|44 col 5| OCamlCompat.String.get(s, 0)

Copy link

vercel bot commented Jun 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rescript-lang.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2024 3:07am

@fhammerschmidt
Copy link
Member

Thanks. Yeah let's remove that OCamlCompat methods later

@fhammerschmidt fhammerschmidt merged commit 7cfe243 into master Jun 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants