Skip to content

Make rewatch the default build system / cli #7593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Jul 3, 2025

This follows up on the work done in #7551 to actually make rewatch the default build system and CLI.

The changes also make it clear - see usage of rescript legacy build - that rewatch is not currently able to build the various test repos other than its own (dependencies not found, panics). This needs to be investigated separately (see #7117).

Closes #7588

Next up: #7589

@cknitt cknitt force-pushed the rewatch-default-cli branch from 19599c7 to d20cf6d Compare July 4, 2025 08:54
@cknitt cknitt force-pushed the rewatch-default-cli branch from d20cf6d to 4adf7a7 Compare July 4, 2025 09:09
@cknitt cknitt force-pushed the rewatch-default-cli branch 2 times, most recently from 86a3443 to ebe9d25 Compare July 4, 2025 11:00
Copy link

pkg-pr-new bot commented Jul 4, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7593

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7593

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7593

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7593

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7593

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7593

commit: 9dbcb42

@cknitt cknitt force-pushed the rewatch-default-cli branch from ebe9d25 to 6cac813 Compare July 4, 2025 11:11
@cknitt cknitt force-pushed the rewatch-default-cli branch from 26d2bea to 80e7d1e Compare July 4, 2025 12:05
@cknitt cknitt changed the title WIP: Make rewatch the default build system / cli Make rewatch the default build system / cli Jul 4, 2025
@cknitt cknitt marked this pull request as ready for review July 4, 2025 12:24
@cknitt cknitt requested review from jfrolich, Bushuo and zth July 4, 2025 12:29
@nojaf
Copy link
Collaborator

nojaf commented Jul 4, 2025

@cknitt worked like a charm for me. Was able to replace all rewatch commands with rescript without any problems.

Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one question.

@@ -13,14 +13,14 @@
]
},
"dependencies": {
"rescript": "12.0.0-alpha.13"
"rescript": "https://pkg.pr.new/rescript-lang/rescript@6cac813"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make rewatch the main cli and default build system
3 participants