-
Notifications
You must be signed in to change notification settings - Fork 469
Make rewatch the default build system / cli #7593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
19599c7
to
d20cf6d
Compare
d20cf6d
to
4adf7a7
Compare
86a3443
to
ebe9d25
Compare
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
ebe9d25
to
6cac813
Compare
26d2bea
to
80e7d1e
Compare
@cknitt worked like a charm for me. Was able to replace all rewatch commands with rescript without any problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one question.
@@ -13,14 +13,14 @@ | |||
] | |||
}, | |||
"dependencies": { | |||
"rescript": "12.0.0-alpha.13" | |||
"rescript": "https://pkg.pr.new/rescript-lang/rescript@6cac813" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct?
This follows up on the work done in #7551 to actually make rewatch the default build system and CLI.
The changes also make it clear - see usage of
rescript legacy build
- that rewatch is not currently able to build the various test repos other than its own (dependencies not found, panics). This needs to be investigated separately (see #7117).Closes #7588
Next up: #7589