Added Callback cli

[Madraceee]

Description

Added callback cli. Invokes the inbuilt commands.

This is not finished

1. What should the value of requestID be. UUID or some string?
2. For url and default, how should those values be passed?

Sry I was busy with my work, could not look into what should be passed for callbacks which dont require a json

To-Do

• Fix RequestID
• Fix non json flow

[Madraceee]

@dfarr I couldnt find an option to request for review , so can you help me out?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 100 lines in your changes missing coverage. Please review.

Project coverage is 54.91%. Comparing base (6b6ee59) to head (18216d1).

Files with missing lines	Patch %	Lines
cmd/callbacks/create.go	0.00%	72 Missing ⚠️
cmd/callbacks/callbacks.go	0.00%	28 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
- Coverage   55.25%   54.91%   -0.35%     
==========================================
  Files         119      121       +2     
  Lines       13753    13853     +100     
==========================================
+ Hits         7599     7607       +8     
- Misses       5690     5783      +93     
+ Partials      464      463       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dfarr]

So sorry for the delay in getting back to you on this PR. The recv flag is so tricky because it can be either a string or a json object in the form {"type": "", data: {}}.

I played around a little with this, what do you think about this approach?

var recv v1.Recv

if json.Valid([]byte(recvStr)) {
	var recv0 v1.Recv0

	if err := json.Unmarshal([]byte(recvStr), &recv0); err != nil {
		return err
	}
	if err := recv.FromRecv0(recv0); err != nil {
		return err
	}
} else {
	if err := recv.FromRecv1(recvStr); err != nil {
		return err
	}
}

This unmarshals the provided value to a v1.Recv0 if the value provided by the user is valid json, otherwise we assume it's a string. That way the user can provide one or the other, for example:

# string example
go run ./... callbacks create --promise-id foo --root-promise-id bar --recv default

# json example
go run ./... callbacks create --promise-id foo --root-promise-id bar --recv '{"type":"poll", "data":{"group":"default","id":"0"}}'

[dfarr]

We can remove requestId from the CLI, its an optional parameter that is more handy for web applications, you can pass nil to CreateCallbackWithResponse for the params.

[dfarr]

We can mark this one as required

[dfarr]

We can also mark this one as required

[dfarr]

I think we can put a sensible default here, maybe 1m?

[dfarr]

We can put default (literally) as the default for recv

[Madraceee]

I am not well. I will look into this next week. Is that fine?

[dfarr]

I am not well. I will look into this next week. Is that fine?

Of course, take your time and hope you get well soon!