Bugfix support overlap option #601
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 27, 2017 17:02
If overlap is set to false, we don't want to enqueue jobs if there's already one running or enqueued.
Add new method to get the queue_name and check if enqueuing is allowed.
carsonreinke
reviewed
Mar 6, 2017
lib/resque/scheduler.rb
Outdated
| end | ||
| return true if currently_processing | ||
|
|
||
| Resque.peek(queue_name, 0, 5000).any? |
There was a problem hiding this comment.
Whats this jazz about?
There was a problem hiding this comment.
Trying to figure out, if there's either a worker still working on the scheduled job or there's already one in the queue.
Granted, it's awkward. I updated the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #504 for recurring jobs. I'm not sure if the behavior should be the same for delayed jobs. Can be added easily, though.