Fix Resque::Scheduler.print_schedule
#794
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in resque@893f13c, this is intended to help with debugging. The `:t` and `:last` attrs were removed in the jmettraux/rufus-scheduler@v2.0.24...v3.0.0 It seems `#print_schedule` likely hasn't worked since the `rufus-scheduler` depenency was bumped to require ~3.0 in resque@d24657e#diff-9732d81ad66d6656923a3883e83f6620a3b16a07484745677a0776f6e0bff025. This fixes the `OpenStruct` warnings seen in tests for newer Ruby versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in 893f13c, this is intended to help with debugging. The
:tand:lastattrs were removed in therufus-scheduler2.0 -> 3.0 updateIt seems
#print_schedulelikely hasn't worked since therufus-schedulerdepenency was bumped to require ~3.0 in d24657e - and could possibly be removed instead (considering the amount of time since then without a report).This fixes the
OpenStructwarnings seen in tests for newer Ruby versions (example failure - coupled with #793 this should get CI back to 🟢 see all tests passing with both changes here)