Open
Conversation
Move stream handler waits (stdout/stderr) to before status logging, ensuring all subprocess output is fully flushed before "success" or "skipped" messages are written. This eliminates a race condition where the main thread could write status messages before the output handler asyncs finished reading subprocess output. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/App.hs, ensuring all subprocess output is fully flushed before "success" or "skipped" messages are writtenRoot Cause
After
waitForProcessreturns, the main thread immediately writes status messages (e.g.logInfo "success") viatoplevelStderr. However, thestdoutHandlerasync (reading subprocess stdout viatoplevelStdout) was only awaited later. Both handles write to the same merged pipe in test mode, so on ARM64 (with different scheduler behavior) the status message could appear before the last subprocess output line.Test plan
SKIP_SLOW_TESTS=1 SKIP_S3_TESTS=1 stack test🤖 Generated with Claude Code