Add group-accessible-repos option#308
Merged
MichaelEischer merged 4 commits intorestic:masterfrom Feb 17, 2025
Merged
Conversation
The group-accessible-repos option will let filesystem group id be able to access files and dir within the restic repo Default stick with old behaviour to be owner restricted While here make dirMode and fileMode within Options struct private
7 tasks
Member
Can you explain what you see as problem with this variant? Write access for groups is by default still blocked via default umask of The usecase of read-only access for syncthing is also easily possible via added ACLs that grant only read access to groups. So probably the standard setup would be to have a user+group rest-server which own the data managed by the rest-server. syncthing has its own separate groups and then is granted read access via ACLs. |
Closed
MichaelEischer
force-pushed
the
group-accessible-repos
branch
from
35d0b69 to
f116937
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The group-accessible-repos option will let filesystem group id be able to access files and dir within the restic repo
What is the purpose of this change? What does it change?
Add a new option flag to enable group access to repo files
Was the change discussed in an issue or in the forum before?
This is try two to enable #189 as discussed in #190
I've followed @MichaelEischer suggestion to have group write access too when this option is enabled, but I don't like it.
Checklist
changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits