Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rhel-10 and centos-stream-10 #323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dzickusrh
Copy link

@dzickusrh dzickusrh commented Sep 6, 2024

This patch fixes two build issues with CentOS-Stream 10. The first is
using pcre2-static instead of pcre-static. The second is to handle a
ppc failure that seems related to the build_type_safety_check_c put in
for Fedora > 40. RHEL-10 is inheriting the same problem.

@p3ck
Copy link
Contributor

p3ck commented Sep 6, 2024

Does it fail to build at all? Do you get an error message? We are also seeing selinux events when run on ppc64 and el10.

@dzickusrh
Copy link
Author

@p3ck - sorry my description was poor. The first part fails to build thanks to increase compiler flags in f40 (which is inherited by rhel-10), see commit 3e4eef4. The second part fails to find the pcre-static dep because it doesn't exist in cs10, but pcre2-static does.

The ppc failure might be related to the build_type_safety_c change in my commit. Try it. :-)

@dzickusrh
Copy link
Author

@p3ck @StykMartin - poke? I just updated the commit description which retriggered CI

@StykMartin
Copy link
Contributor

@dzickusrh could you please also update Packit configuration? I can see that COPR has build targets for CentOS Stream 10 and EPEL 10

@dzickusrh
Copy link
Author

dzickusrh commented Nov 6, 2024

@StykMartin - is it just add cs10 to .packit.yml? (copy cs9 to cs10) or was there another file too?

Should I also update the .github/workflow files to remove fedora 38 and use fedora 41?

This patch fixes two build issues with CentOS-Stream 10.  The first is
using pcre2-static instead of pcre-static.  The second is to handle a
ppc failure that seems related to the build_type_safety_check_c put in
for Fedora > 40.  RHEL-10 is inheriting the same problem.

Update packit.yml file to include CentOS-Stream-10.

Signed-off-by: Don Zickus <[email protected]>
@StykMartin
Copy link
Contributor

StykMartin commented Nov 6, 2024

@StykMartin - is it just add cs10 to .packit.yml? (copy cs9 to cs10) or was there another file too?

This is fine. CS10 in .packit.yaml was what I wanted.

Should I also update the .github/workflow files to remove fedora 38 and use fedora 41?

I will handle GH action is separate PR so you don't have to worry, I have seen that we are using some deprecated actions and I will need to replace them as well.

What is problematic is, we Packit can't build the C10.

No matches found for the following disable plugin patterns: local, spacewalk, versionlock
Copr repository                                 107 kB/s | 1.5 kB     00:00    
CentOS Stream 10 - BaseOS                        28 kB/s | 5.6 kB     00:00    
CentOS Stream 10 - AppStream                     46 kB/s | 5.7 kB     00:00    
CentOS Stream 10 - CRB                          168 kB/s | 5.5 kB     00:00    
CentOS Stream 10 - Extras packages               28 kB/s | 6.1 kB     00:00    
No matching package to install: 'libsoup-devel'
Package pkgconf-pkg-config-2.1.0-3.el10.x86_64 is already installed.
Package tar-2:1.35-5.el10.x86_64 is already installed.
Not all dependencies satisfied
Error: Some packages could not be found.

We are missing libsoup-devel

@dzickusrh
Copy link
Author

@StykMartin - is it just add cs10 to .packit.yml? (copy cs9 to cs10) or was there another file too?

This is fine. CS10 in .packit.yaml was what I wanted.

Should I also update the .github/workflow files to remove fedora 38 and use fedora 41?

I will handle GH action is separate PR so you don't have to worry, I have seen that we are using some deprecated actions and I will need to replace them as well.

What is problematic is, we Packit can't build the C10.

No matches found for the following disable plugin patterns: local, spacewalk, versionlock
Copr repository                                 107 kB/s | 1.5 kB     00:00    
CentOS Stream 10 - BaseOS                        28 kB/s | 5.6 kB     00:00    
CentOS Stream 10 - AppStream                     46 kB/s | 5.7 kB     00:00    
CentOS Stream 10 - CRB                          168 kB/s | 5.5 kB     00:00    
CentOS Stream 10 - Extras packages               28 kB/s | 6.1 kB     00:00    
No matching package to install: 'libsoup-devel'
Package pkgconf-pkg-config-2.1.0-3.el10.x86_64 is already installed.
Package tar-2:1.35-5.el10.x86_64 is already installed.
Not all dependencies satisfied
Error: Some packages could not be found.

Oh? I can ask the CentOS-stream folks where this package is. What repos are we using or is that a PackIt internal thing? I ask because I can imaging libsoup-devel is in a different repo than the normal packages.

We are missing libsoup-devel

@StykMartin
Copy link
Contributor

No, we shouldn't run into problems like that. The COPR build root should be set up so that all standard packages are available.

I need to check which repository we can find this package in (if any) and why the COPR/Packit build is not set up correctly.

@dzickusrh
Copy link
Author

I reached out to the PackIt team about this, but perhaps I should poke the COPR team instead?

@StykMartin
Copy link
Contributor

Yeah. I mean this has nothing to do with Packit. They just provide the service to automatically provide builds via COPR. If we can build restraint in BREW and we can't achieve the same in COPR then something is off.

@StykMartin
Copy link
Contributor

CS9

[root@14d9e9295ac8 /]# yum info libsoup-devel
Last metadata expiration check: 0:00:08 ago on Fri Nov  8 06:12:17 2024.
Available Packages
Name         : libsoup-devel
Version      : 2.72.0
Release      : 8.el9
Architecture : aarch64
Size         : 179 k
Source       : libsoup-2.72.0-8.el9.src.rpm
Repository   : appstream
Summary      : Header files for the Soup library
URL          : https://wiki.gnome.org/Projects/libsoup
License      : LGPLv2
Description  : Libsoup is an HTTP library implementation in C. This package allows
             : you to develop applications that use the libsoup library.

CS10

[root@e8e13dc185e3 /]# yum info libsoup-devel
Last metadata expiration check: 0:07:57 ago on Fri Nov  8 01:05:39 2024.
Error: No matching Packages to list
[root@e8e13dc185e3 /]# yum info libsoup3-devel
Last metadata expiration check: 0:07:59 ago on Fri Nov  8 01:05:39 2024.
Available Packages
Name         : libsoup3-devel
Version      : 3.4.4
Release      : 6.el10
Architecture : aarch64
Size         : 124 k
Source       : libsoup3-3.4.4-6.el10.src.rpm
Repository   : appstream
Summary      : Header files for the Soup library
URL          : https://wiki.gnome.org/Projects/libsoup
License      : LGPL-2.0-or-later
Description  : Libsoup is an HTTP library implementation in C. This package allows
             : you to develop applications that use the libsoup library.

Looks like we have only Libsoup 3 version in CS10. We will need to investigate 2/3 compat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants