-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for rhel-10 and centos-stream-10 #323
base: master
Are you sure you want to change the base?
Conversation
Does it fail to build at all? Do you get an error message? We are also seeing selinux events when run on ppc64 and el10. |
@p3ck - sorry my description was poor. The first part fails to build thanks to increase compiler flags in f40 (which is inherited by rhel-10), see commit 3e4eef4. The second part fails to find the pcre-static dep because it doesn't exist in cs10, but pcre2-static does. The ppc failure might be related to the build_type_safety_c change in my commit. Try it. :-) |
3ba4712
to
1c2fc4d
Compare
@p3ck @StykMartin - poke? I just updated the commit description which retriggered CI |
@dzickusrh could you please also update Packit configuration? I can see that COPR has build targets for CentOS Stream 10 and EPEL 10 |
@StykMartin - is it just add cs10 to .packit.yml? (copy cs9 to cs10) or was there another file too? Should I also update the .github/workflow files to remove fedora 38 and use fedora 41? |
This patch fixes two build issues with CentOS-Stream 10. The first is using pcre2-static instead of pcre-static. The second is to handle a ppc failure that seems related to the build_type_safety_check_c put in for Fedora > 40. RHEL-10 is inheriting the same problem. Update packit.yml file to include CentOS-Stream-10. Signed-off-by: Don Zickus <[email protected]>
1c2fc4d
to
ce66cf4
Compare
This is fine. CS10 in .packit.yaml was what I wanted.
I will handle GH action is separate PR so you don't have to worry, I have seen that we are using some deprecated actions and I will need to replace them as well. What is problematic is, we Packit can't build the C10.
We are missing libsoup-devel |
Oh? I can ask the CentOS-stream folks where this package is. What repos are we using or is that a PackIt internal thing? I ask because I can imaging libsoup-devel is in a different repo than the normal packages.
|
No, we shouldn't run into problems like that. The COPR build root should be set up so that all standard packages are available. I need to check which repository we can find this package in (if any) and why the COPR/Packit build is not set up correctly. |
I reached out to the PackIt team about this, but perhaps I should poke the COPR team instead? |
Yeah. I mean this has nothing to do with Packit. They just provide the service to automatically provide builds via COPR. If we can build restraint in BREW and we can't achieve the same in COPR then something is off. |
CS9
CS10
Looks like we have only Libsoup 3 version in CS10. We will need to investigate 2/3 compat |
This patch fixes two build issues with CentOS-Stream 10. The first is
using pcre2-static instead of pcre-static. The second is to handle a
ppc failure that seems related to the build_type_safety_check_c put in
for Fedora > 40. RHEL-10 is inheriting the same problem.