Skip to content

feat: add endpoint to create many templates at once. #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 3, 2024

Conversation

oliverqx
Copy link
Contributor

@oliverqx oliverqx commented Jun 1, 2024

Thank you for contributing to Retraced!

Please add a summary of your change

Adds a new endpoint that expects the following object:

{
    templates: TemplateValues[]
}

will create many templates to the same project and environment at once.

Does your change fix a particular issue?

Not an issue. Will be used by my cal.com integration to setup a list of default templates for all events that cal.com will report.

@deepakprabhakara
Copy link

@ukrocks007 Your suggestion to use bulk convention sounds good, @oliverqx you can ignore my earlier comments.

@oliverqx oliverqx requested a review from ukrocks007 June 24, 2024 15:02
@oliverqx oliverqx requested a review from ukrocks007 July 3, 2024 01:06
@oliverqx
Copy link
Contributor Author

oliverqx commented Jul 3, 2024

just addressed the changes, thanks for reviewing my code

@ukrocks007 ukrocks007 changed the base branch from main to bulk-template-api July 3, 2024 06:47
@ukrocks007 ukrocks007 merged commit 8373a34 into retracedhq:bulk-template-api Jul 3, 2024
4 of 5 checks passed
ukrocks007 added a commit that referenced this pull request Jul 8, 2024
* feat: add endpoint to create many templates at once. (#1430)

* feat: add endpoint to create many templates at once.

* fix: comply with id unique constraint by declaring it inside loop

* fix: update api endpoint to comply with standard

Co-authored-by: Utkarsh Mehta <[email protected]>

* fix: revert change to original endpoint

* fix: add limit to template bulk creation endpoint

* fix: lint

Co-authored-by: Utkarsh Mehta <[email protected]>

* fix: template limit and move checkAdminAccessUnwrapped to avoid unnecessary calls

* fix: change many->bulk

---------

Co-authored-by: Utkarsh Mehta <[email protected]>

* chore: format

* feat: support array for template and single template in createTemplate handler

* feat: add TemplateResponse type to createTemplate handler

* feat: add CreateTemplateBulk#createTemplate() method for bulk template creation

This commit adds a new method `CreateTemplateBulk#createTemplate()` to handle the bulk creation of templates. The method takes in an array of template objects and creates them in the database. It also includes necessary error handling and cleanup.

* feat: fixes

* lint

---------

Co-authored-by: oliver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants