New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: channelId on messageUpdate & honour partial objects #97

Merged

insertish merged 3 commits into revoltchat:master from austinhuang0131:master

Jun 8, 2024

Contributor

austinhuang0131 commented Jun 5, 2024

fe325e3 adds channel ID (which is supplied by the event) onto partial messages, for those who enabled partials in ClientOptions.
3ffa0e7 makes partial properties actually persist in storage (otherwise isPartial is useless).
16b1e60 allows partial objects to be converted to full objects whenever the respective fetch methods are called.

Please make sure to check the following tasks before opening and submitting a PR

I understand and have followed the contribution guide
I have tested my changes locally and they are working as intended

austinhuang0131 added 3 commits

June 4, 2024 18:24


          fix: add channelId on MessageUpdate and MessageAppend

fe325e3


          fix: do not hydrate partial property

3ffa0e7


          fix: fetch should fill out partial objects

16b1e60

insertish approved these changes

View reviewed changes

insertish merged commit 41b176c into revoltchat:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet