fix aic8800 WiFi & BT on lichee-pi-4a

[nekorouter]

fix aic8800 WiFi & BT on lichee-pi-4a

• fix rfkill not working to properly toggle gpio for aic8800 (thanks to @KamijoToma for resolving this bug)
• add uart1 & uart3
• cherry-pick sdhci-of-dwcmshc fix from upstream (torvalds@27e8fe0)
• fix bluetooth tty number to ttyS4
• rollback to manually attach rtl8723 HCI port using systemd script
• update aic8800 driver to 20241119 (v4.0)

Summary by Sourcery

Fix GPIO-based RF kill handling and module configuration for the AIC8800 wireless on the Lichee-Pi-4A.

Enhancements:

• Use of_get_named_gpio instead of deprecated of_find_gpio/desc_to_gpio for WiFi and Bluetooth power pins
• Add null checks around gpio_free and driver data deallocation in rfkill-wlan remove path

Build:

• Switch rfkill-wlan.o and rfkill-bt.o from built-in (obj-y) to loadable modules (obj-m)

[sourcery-ai]

Reviewer's Guide

This PR refactors RFKill GPIO handling to use the DT-friendly of_get_named_gpio interface with updated property names, strengthens cleanup logic, switches the WLAN/BT drivers to build as loadable modules, enables UART1/3 in the Lichee-Pi-4A device tree, and bumps the AIC8800 Wi-Fi driver to v4.0.

ER diagram for device tree UART additions

erDiagram
    SOC ||--o{ UART1 : enables
    SOC ||--o{ UART3 : enables
    SOC {
        string name
    }
    UART1 {
        int id
        string status
    }
    UART3 {
        int id
        string status
    }

Loading

File-Level Changes

Change	Details	Files
Standardize RFKill GPIO initialization via of_get_named_gpio	Replaced of_find_gpio + desc_to_gpio with of_get_named_gpio Updated DT property names to "WIFI,poweren-gpios" and "BT,power-gpios" Adjusted LOG messages to reflect new GPIO values	net/rfkill/rfkill-wlan.c net/rfkill/rfkill-bt.c
Harden RFKill WLAN cleanup path	Added null-pointer guards around gpio_free and kfree Commented out obsolete gpio_is_valid check Ensured rfkill struct is only freed if non-null	net/rfkill/rfkill-wlan.c
Convert WLAN/BT RFKill drivers to loadable modules	Changed obj-y to obj-m for rfkill-wlan.o and rfkill-bt.o in Makefile	net/rfkill/Makefile
Expose UART1 and UART3 in Lichee-Pi-4A Device Tree	Added pinctrl configurations for uart1 and uart3 Updated aliases and pin-mux nodes accordingly	arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
Upgrade AIC8800 Wi-Fi driver to version 4.0	Bumped driver version to v4.0 Updated API calls and init routines to match v4.0 changes Adjusted Kconfig/Makefile entries for new driver	drivers/net/wireless/aic8800/*

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @nekorouter - I've reviewed your changes - here's some feedback:

• The PR description mentions adding UART1 & UART3 entries, but I don’t see any DTS updates for those in the diff—please include them or remove that reference to avoid confusion.
• Since you’re converting rfkill-wlan and rfkill-bt into loadable modules, please verify that Kconfig/module dependencies are updated so they load in the correct order under CONFIG_RFKILL_GPIO.
• Consider switching to the gpiod descriptor API (e.g. devm_gpiod_get_optional()) for GPIO handling to simplify resource management instead of manual of_get_named_gpio()/gpio_free() calls.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- The PR description mentions adding UART1 & UART3 entries, but I don’t see any DTS updates for those in the diff—please include them or remove that reference to avoid confusion.
- Since you’re converting rfkill-wlan and rfkill-bt into loadable modules, please verify that Kconfig/module dependencies are updated so they load in the correct order under CONFIG_RFKILL_GPIO.
- Consider switching to the gpiod descriptor API (e.g. devm_gpiod_get_optional()) for GPIO handling to simplify resource management instead of manual of_get_named_gpio()/gpio_free() calls.

## Individual Comments

### Comment 1
<location> `net/rfkill/rfkill-wlan.c:198` </location>
<code_context>
 	struct rfkill_wlan_data *rfkill = platform_get_drvdata(pdev);

-	if (gpio_is_valid(rfkill->pdata->power_n.io))
+//	if (gpio_is_valid(rfkill->pdata->power_n.io))
+	if (rfkill && rfkill->pdata && gpio_is_valid(rfkill->pdata->power_n.io))
 		gpio_free(rfkill->pdata->power_n.io);
-
</code_context>

<issue_to_address>
Added null checks for rfkill and rfkill->pdata before gpio_is_valid.

If rfkill or rfkill->pdata is null, it may signal a logic issue elsewhere. Consider adding logging or explicit handling for these cases.
</issue_to_address>

<suggested_fix>
<<<<<<< SEARCH
//	if (gpio_is_valid(rfkill->pdata->power_n.io))
	if (rfkill && rfkill->pdata && gpio_is_valid(rfkill->pdata->power_n.io))
		gpio_free(rfkill->pdata->power_n.io);
=======
	if (!rfkill) {
		pr_err("%s: rfkill is NULL in %s\n", __func__, __FILE__);
	} else if (!rfkill->pdata) {
		pr_err("%s: rfkill->pdata is NULL in %s\n", __func__, __FILE__);
	} else if (gpio_is_valid(rfkill->pdata->power_n.io)) {
		gpio_free(rfkill->pdata->power_n.io);
	}
>>>>>>> REPLACE

</suggested_fix>

### Comment 2
<location> `net/rfkill/rfkill-wlan.c:201` </location>
<code_context>
 		gpio_free(rfkill->pdata->power_n.io);
-
-	kfree(rfkill);
+	if (rfkill)
+		kfree(rfkill);
 	g_rfkill = NULL;

</code_context>

<issue_to_address>
Redundant null check before kfree.

Since kfree handles NULL pointers safely, you can remove the explicit null check to simplify the code.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion: Added null checks for rfkill and rfkill->pdata before gpio_is_valid.

If rfkill or rfkill->pdata is null, it may signal a logic issue elsewhere. Consider adding logging or explicit handling for these cases.

Suggested change

	// if (gpio_is_valid(rfkill->pdata->power_n.io))
	if (rfkill && rfkill->pdata && gpio_is_valid(rfkill->pdata->power_n.io))
	gpio_free(rfkill->pdata->power_n.io);
	if (!rfkill) {
	pr_err("%s: rfkill is NULL in %s\n", __func__, __FILE__);
	} else if (!rfkill->pdata) {
	pr_err("%s: rfkill->pdata is NULL in %s\n", __func__, __FILE__);
	} else if (gpio_is_valid(rfkill->pdata->power_n.io)) {
	gpio_free(rfkill->pdata->power_n.io);
	}

[sourcery-ai]

nitpick: Redundant null check before kfree.

Since kfree handles NULL pointers safely, you can remove the explicit null check to simplify the code.