Skip to content

Enable Console4a (mainly display & charger) #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025

Conversation

nekorouter
Copy link

@nekorouter nekorouter commented Jul 11, 2025

  • enable drm panel driver and gpio charger driver kernel config for console4A
  • fix model name to LicheeConsole4A
  • add power key (gpio-keys)
  • fix gpio-charger gpio pin number
  • disable UART3_TXD pin because of gpio-charger occupied this pin
  • fix UART3_RXD pin mode to uart (rx for EC chip)
  • remove bluetooth definition in uart4 (console4A uses aic8800)
  • some tidy up (reveres to default values or delete useless comments)

Summary by Sourcery

Configure Console4A hardware support by enabling display and charger drivers, adding a power key, fixing GPIO and UART assignments, updating the model name, and cleaning up the device tree

New Features:

  • Enable DRM panel driver and GPIO charger driver in kernel config
  • Add a GPIO-based power key to the device tree

Enhancements:

  • Correct the model name to LicheeConsole4A
  • Update charger GPIO pin assignment to the proper pin number
  • Disable UART3_TXD to free the pin for the charger and set UART3_RXD to UART mode
  • Remove Bluetooth function from UART4 since Console4A uses the AIC8800
  • Clean up device tree by reverting to default values and removing obsolete comments

Enable drm panel driver and gpio charger driver support for console4A.

Signed-off-by: NekoRouter <[email protected]>
…ey/bluetooth

- fix model name to LicheeConsole4A
- add power key (gpio-keys)
- fix gpio-charger gpio pin number
- disable UART3_TXD pin because of gpio-charger occupied this pin
- fix UART3_RXD pin mode to uart (rx for EC chip)
- remove bluetooth definition in uart4 (console4A uses aic8800)
- some tidy up (reveres to default values or delete useless comments)

Signed-off-by: NekoRouter <[email protected]>
Copy link

sourcery-ai bot commented Jul 11, 2025

Reviewer's Guide

This PR configures the Console4A (LicheeConsole4A) platform by enabling the DRM panel and GPIO charger drivers in the kernel config and overhauls the device tree: correcting the model name, adding a power key node, adjusting charger and UART pin settings, removing unused Bluetooth definitions, and cleaning up defaults and comments.

File-Level Changes

Change Details Files
Enable DRM panel and GPIO charger support in kernel configuration
  • Enabled DRM panel driver option
  • Enabled GPIO charger driver option
arch/riscv/configs/revyos_defconfig
Update device tree to support Console4A board
  • Fixed board model name to LicheeConsole4A
  • Added gpio-keys node for power button
  • Corrected gpio-charger pin number and disabled UART3_TXD
  • Reconfigured UART3_RXD pin mode to UART for EC chip
  • Removed Bluetooth UART4 definition (uses AIC8800)
  • Tidied default values and removed obsolete comments
arch/riscv/boot/dts/thead/th1520-lpi4a-console.dts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nekorouter - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@RevySR RevySR merged commit b436bfe into revyos:th1520-lts Jul 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants