Skip to content

drm/panel: mingjun: use gpiod_set_value_cansleep #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

Icenowy
Copy link

@Icenowy Icenowy commented Jul 14, 2025

For power sequencing that do not require strict timing, gpiod_set_value_cansleep is usually used.

Do the same thing on the mingjun panel driver.

This fixes some warnings on Lichee Console 4A.

Summary by Sourcery

Bug Fixes:

  • Replace reset GPIO toggles with gpiod_set_value_cansleep to fix warnings on platforms requiring can-sleep GPIO calls

For power sequencing that do not require strict timing,
gpiod_set_value_cansleep is usually used.

Do the same thing on the mingjun panel driver.

This fixes some warnings on Lichee Console 4A.

Signed-off-by: Icenowy Zheng <[email protected]>
Copy link

sourcery-ai bot commented Jul 14, 2025

Reviewer's Guide

Refactor the mingjun panel driver to replace direct GPIO toggles with the sleep-capable API for reset control, ensuring correct context usage and silencing warnings on Lichee Console 4A.

Class diagram for mingjun panel driver GPIO usage update

classDiagram
    class mingjun_panel_info {
        +struct gpio_desc *reset
        +struct regulator *hsvcc
        +struct regulator *vspn3v3
        +bool prepared
    }
    class mingjun_panel_driver {
        +int mingjun_prepare(struct drm_panel *panel)
        +int mingjun_unprepare(struct drm_panel *panel)
    }
    mingjun_panel_driver --> mingjun_panel_info : uses
    mingjun_panel_driver : - gpiod_set_value(pinfo->reset, X)
    mingjun_panel_driver : + gpiod_set_value_cansleep(pinfo->reset, X)
Loading

File-Level Changes

Change Details Files
Use gpiod_set_value_cansleep for reset GPIO instead of gpiod_set_value
  • Replace reset toggle in unprepare sequence
  • Replace initial reset deassert in prepare
  • Replace reset assert after power-on delay
  • Replace reset assert in failure cleanup
drivers/gpu/drm/panel/panel-mingjun-070bi30ia2.c

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Icenowy Icenowy requested a review from nekorouter July 14, 2025 20:03
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Icenowy - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@RevySR RevySR merged commit 8a8840f into revyos:th1520-lts Jul 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants