forked from torvalds/linux
-
Notifications
You must be signed in to change notification settings - Fork 10
Th1520 6.6 oot build fix #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis patch fixes out-of-tree build issues by switching panel reset GPIO calls to the sleep-capable variant and adjusting Makefile include paths to reference $(srctree) for correct header resolution. Class diagram for updated panel reset GPIO usageclassDiagram
class mingjun_panel_info {
+struct gpio_desc *reset
+struct regulator *hsvcc
+struct regulator *vspn3v3
+bool prepared
}
class drm_panel {
<<interface>>
}
mingjun_panel_info --|> drm_panel
class panel_mingjun_070bi30ia2 {
+int mingjun_prepare(struct drm_panel *panel)
+int mingjun_unprepare(struct drm_panel *panel)
}
panel_mingjun_070bi30ia2 ..> mingjun_panel_info : uses
panel_mingjun_070bi30ia2 : +gpiod_set_value_cansleep(reset, value)
%% Note: gpiod_set_value replaced with gpiod_set_value_cansleep in methods
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Fix use of $(src) without $(srctree) in Makefile's which prevents out-of-tree build. Signed-off-by: Icenowy Zheng <[email protected]>
d8e61ed
to
d4d0769
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RevySR
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Fix out-of-tree build compatibility by adjusting include paths in xuantie NNA subdirectories and improve panel reset GPIO handling by using the sleeping-capable gpiod_set_value_cansleep API
Enhancements: