Skip to content

Th1520 6.6 oot build fix #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

Icenowy
Copy link

@Icenowy Icenowy commented Jul 15, 2025

Summary by Sourcery

Fix out-of-tree build compatibility by adjusting include paths in xuantie NNA subdirectories and improve panel reset GPIO handling by using the sleeping-capable gpiod_set_value_cansleep API

Enhancements:

  • Switch to gpiod_set_value_cansleep in the panel-mingjun-070bi30ia2 driver for the reset GPIO
  • Update Makefiles in xuantie NNA nexef_platform and img_mem to use srctree-based include paths

Copy link

sourcery-ai bot commented Jul 15, 2025

Reviewer's Guide

This patch fixes out-of-tree build issues by switching panel reset GPIO calls to the sleep-capable variant and adjusting Makefile include paths to reference $(srctree) for correct header resolution.

Class diagram for updated panel reset GPIO usage

classDiagram
    class mingjun_panel_info {
        +struct gpio_desc *reset
        +struct regulator *hsvcc
        +struct regulator *vspn3v3
        +bool prepared
    }
    class drm_panel {
        <<interface>>
    }
    mingjun_panel_info --|> drm_panel
    class panel_mingjun_070bi30ia2 {
        +int mingjun_prepare(struct drm_panel *panel)
        +int mingjun_unprepare(struct drm_panel *panel)
    }
    panel_mingjun_070bi30ia2 ..> mingjun_panel_info : uses
    panel_mingjun_070bi30ia2 : +gpiod_set_value_cansleep(reset, value)
    %% Note: gpiod_set_value replaced with gpiod_set_value_cansleep in methods
Loading

File-Level Changes

Change Details Files
Replace gpiod_set_value with gpiod_set_value_cansleep for panel reset
  • Use gpiod_set_value_cansleep in unprepare
  • Use gpiod_set_value_cansleep at the start of prepare
  • Use gpiod_set_value_cansleep after power-up delay
  • Use gpiod_set_value_cansleep in error cleanup
drivers/gpu/drm/panel/panel-mingjun-070bi30ia2.c
Prefix include directories with $(srctree) to support out-of-tree builds
  • Update nexef_platform Makefile include paths
  • Update img_mem Makefile include path
drivers/soc/xuantie/nna/nexef_platform/Makefile
drivers/soc/xuantie/nna/img_mem/Makefile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Fix use of $(src) without $(srctree) in Makefile's which prevents
out-of-tree build.

Signed-off-by: Icenowy Zheng <[email protected]>
@Icenowy Icenowy force-pushed the th1520-6.6-oot-build-fix branch from d8e61ed to d4d0769 Compare July 15, 2025 13:37
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Icenowy - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@RevySR RevySR merged commit 65074f1 into revyos:th1520-lts Jul 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants