Lots of plugins #137
Draft
Lots of plugins #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 5, 2017 15:05
And so that it always wipes out all items.
The previous `show_delay` was incorrect. It was changing the speed of the transition, not the delay before the transition started. I left `show_delay` in there and mapped it to the (incorrect) `auto_hide_speed` for backwards compatibility but removed reference to it from the README.
There's quite a bit of duplication among many of these functions. I'm going to add a few helper functions to clean some of it up. It will make adding new plugins easier as well as make the user experience more consistent. Not to mention cutting down on possible bugs.
This was much too prone to manual error. For now I just went through the commands that were predominantly 'defaults write' commands as that what I'm currently the most focused on. I also removed the duplication of the restarting of processes and made it happen after any command (which has been given a value) has been run.
added 30 commits
January 8, 2017 13:09
Apparently from having many contributors the docs got a bit out of date
(format-wise). Some (most) of the "examples" were actually usage.
Examples should contain sample data. Usage should contain placeholders.
Take the `service` plugin for example:
This is usage:
m service load <service_name>
This is an example:
m service load com.apple.sessionlogoutd
I didn't rewrite everything but I made some good progress.
Some places can't be replaced, but these could
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.