Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edgeclusters.sh): Workaround BZ 2073197 issue with signatures on containers #353

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

iranzo
Copy link
Contributor

@iranzo iranzo commented Jun 2, 2022

Description

Override for BZ 2073197 to override permissions https://bugzilla.redhat.com/show_bug.cgi?id=2073197#c19

Related: openshift/machine-config-operator#1349

Apparently, by mistake, a change in RHCOS image does try to verify signatures for the images, which are not currently mirrored or even provided, and this causes an issue.

There's an upstream issue listed to get this solved, but as a workaround we're disabling verification in Edge clusters via an ignition file and might in addition require a change in the installer image being used until RHCOS has the changes reverted and the related tooling is updated to mirror signatures, etc.

@alknopfler
Copy link
Contributor

/LGTM

@achuzhoy
Copy link
Collaborator

achuzhoy commented Jun 2, 2022

maybe we should instead change the quay.io/ztpfw/pipeline:latest image.


[root@seal10 ~]# podman run  --name sasha4 quay.io/ztpfw/pipeline:latest cat /etc/containers/policy.json
{
    "default": [
        {
            "type": "insecureAcceptAnything"
        }
    ],
    "transports": {
        "docker": {
	    "registry.access.redhat.com": [
		{
		    "type": "signedBy",
		    "keyType": "GPGKeys",
		    "keyPath": "/etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release"
		}
	    ],
	    "registry.redhat.io": [
		{
		    "type": "signedBy",
		    "keyType": "GPGKeys",
		    "keyPath": "/etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release"
		}
	    ]
	},
        "docker-daemon": {
	    "": [
		{
		    "type": "insecureAcceptAnything"
		}
	    ]
	}
    }
}

@flaper87
Copy link
Contributor

flaper87 commented Jun 3, 2022

Could you please add more info to the PR description? It would be useful to know how that BZ affects us, why it affects us, and what the contents of the override in this PR are.

@iranzo
Copy link
Contributor Author

iranzo commented Jun 3, 2022

maybe we should instead change the quay.io/ztpfw/pipeline:latest image.


[root@seal10 ~]# podman run  --name sasha4 quay.io/ztpfw/pipeline:latest cat /etc/containers/policy.json
{
    "default": [
        {
            "type": "insecureAcceptAnything"
        }
    ],
    "transports": {
        "docker": {
	    "registry.access.redhat.com": [
		{
		    "type": "signedBy",
		    "keyType": "GPGKeys",
		    "keyPath": "/etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release"
		}
	    ],
	    "registry.redhat.io": [
		{
		    "type": "signedBy",
		    "keyType": "GPGKeys",
		    "keyPath": "/etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release"
		}
	    ]
	},
        "docker-daemon": {
	    "": [
		{
		    "type": "insecureAcceptAnything"
		}
	    ]
	}
    }
}

Why doing only now when we can do both for the double of price (https://www.imdb.com/title/tt0118884/characters/nm0000457)

Copy link
Contributor

@flaper87 flaper87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@iranzo
Copy link
Contributor Author

iranzo commented Jun 14, 2022

image

@iranzo
Copy link
Contributor Author

iranzo commented Jun 22, 2022

Same failure in 'deploy-metallb' as 'main'

@iranzo
Copy link
Contributor Author

iranzo commented Jun 23, 2022

Copy link
Contributor

@flaper87 flaper87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's curious that the CI job is being re-triggered.

@alknopfler
Copy link
Contributor

regarding the issue with metallb and mirror, in the afternoons I don't know why we're getting this kinds of "retries" with some images...but this is something temporal

The PR is LGTM

Copy link
Contributor

@alknopfler alknopfler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iranzo iranzo merged commit 3d14a8f into main Jun 23, 2022
@iranzo iranzo deleted the signature branch June 23, 2022 13:11
@iranzo
Copy link
Contributor Author

iranzo commented Jun 23, 2022

🎉 This PR is included in version 1.9.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants