Skip to content

Add Voice PE sound files and timer config to docs #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tannisroot
Copy link
Contributor

This PR:

  • Replaces old sound files with new ones from Voice PE
  • Keeps old ones but with a different name
  • Adds timer configuration to 2mic docs

@omaramin-2000
Copy link

Then what about the file that plays after listening "done.wav"?

@tannisroot
Copy link
Contributor Author

Then what about the file that plays after listening "done.wav"?

Voice PE to my knowledge doesn't have the equivalent.

@omaramin-2000
Copy link

Then what about the file that plays after listening "done.wav"?

Voice PE to my knowledge doesn't have the equivalent.

Then it should be kept as it is.

@tannisroot
Copy link
Contributor Author

Then what about the file that plays after listening "done.wav"?

Voice PE to my knowledge doesn't have the equivalent.

Then it should be kept as it is.

It is? This PR doesn't touch it.

@omaramin-2000
Copy link

Look I have an idea, what if we can add an option to choose the sound file from the integration page for both wake work and timer? as there are more than one sound file for each one so let users choose between them easily even if we set one as default.

@tannisroot
Copy link
Contributor Author

I don't really see the point in overcomplicating this.
In ESPHome based satellites they just replaced the sounds without any fuss.

@omaramin-2000
Copy link

I don't really see the point in overcomplicating this. In ESPHome based satellites they just replaced the sounds without any fuss.

Maybe this option would be added to ESPHome too, why not?

@tannisroot
Copy link
Contributor Author

If the user wants a custom sound, they can already do so by choosing a different file when selecting the wake word sound in the config.
The PR doesn't remove legacy sounds, they are still there.

@omaramin-2000
Copy link

omaramin-2000 commented Apr 18, 2025

If the user wants a custom sound, they can already do so by choosing a different file when selecting the wake word sound in the config. The PR doesn't remove legacy sounds, they are still there.

Yes, I understand. I am talking about making it easier to choose from the device integration page at anytime instead of changing the configuration every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants