Skip to content

Commit

Permalink
Build: for now, don't error on RWX loadable segments
Browse files Browse the repository at this point in the history
Right now on some CI builds we get:

  aarch64-linux-gnu-gcc -nostdlib -fPIC -Wl,--warn-common -Wl,--no-undefined \
  	-Wl,--fatal-warnings -Wl,-shared -Wl,-Bsymbolic -L/usr/lib64 \
  	-L/__w/certwrapper/certwrapper/gnu-efi/ -Wl,--build-id=sha1 \
  	-Wl,--hash-style=sysv  -o certmule.so certmule.o sbat_data.o  \
  	/usr/lib/gcc/aarch64-linux-gnu/12/libgcc.a \
  	-T /__w/certwrapper/certwrapper/elf_aarch64_efi.lds
  /usr/bin/aarch64-linux-gnu-ld: warning: certmule.so has a LOAD segment with RWX permissions
  collect2: error: ld returned 1 exit status
  make: *** [../Makefile:115: certmule.so] Error 1

These needs to be fixed separately, but making them not be errors gets
us back to CI working appropriately.

Signed-off-by: Peter Jones <[email protected]>
  • Loading branch information
vathpela committed Jan 17, 2024
1 parent e004c57 commit 0197449
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ BUILDFLAGS := $(CFLAGS) -fPIC -Werror -Wall -Wextra -fshort-wchar \
-I$(GNUEFIDIR)/inc/protocol
CCLDFLAGS ?= -nostdlib -fPIC -Wl,--warn-common \
-Wl,--no-undefined -Wl,--fatal-warnings \
-Wl,--no-warn-rwx-segments \
-Wl,-shared -Wl,-Bsymbolic -L$(LIBDIR) -L$(GNUEFIDIR) \
-Wl,--build-id=sha1 -Wl,--hash-style=sysv
LD = $(CROSS_COMPILE)ld
Expand Down

0 comments on commit 0197449

Please sign in to comment.