Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for versioned x86_64 arches #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewlukoshko
Copy link

Recently Red Hat introduced versioned x86_64 arches support in RPM: x86_64_v2 x86_64_v3 x86_64_v4.
In terms of RPM macros they are different to x86_64 and should be specifically mentioned in ifarch-like conditions.

Hopefully, since Fedora 39 and CS10 there is %{x86_64} macro available:

# rpm --eval %{x86_64}
x86_64 x86_64_v2 x86_64_v3 x86_64_v4 amd64 em64t

This PR adds versioned x86_64 arches support by replacing x86_64 with %{x86_64} where necessary.

But this should be only considered if no more major efi-rpm-macros updates expected in Fedora 38 and RHEL/CS 8/9.
If they are expected then different approach is necessary.

Copy link

@Conan-Kudo Conan-Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants