Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

efibootmgr: delete_bootnext is just a boolean, not an entry id #198

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

dimaz-waymo
Copy link
Contributor

When deleting bootnext, there's nothing to validate (other than the variable existing, in which case del will fail as expected).

This appears to be a copy/paste error when adding the delete-bootnext option from the [create] bootnext option.

When deleting bootnext, there's nothing to validate (other than
the variable existing, in which case del will fail as expected).

This appears to be a copy/paste error when adding the delete-bootnext
option from the [create] bootnext option.

Signed-off-by: Dima Zavin <[email protected]>
@dimaz-waymo
Copy link
Contributor Author

Before the change:

$ efibootmgr
BootNext: 0002
BootCurrent: 0002
...
$ sudo efibootmgr -N
Boot entry 0001 does not exist

After the change

$ sudo src/efibootmgr -N
BootCurrent: 0002
...

I think this has gone unnoticed because most distributions have a Boot0001 entry so this error wasn't raised.

@vathpela vathpela merged commit 0ca99d4 into rhboot:main Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants