Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for RSA3072 and RSA4096. #114

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Add support for RSA3072 and RSA4096. #114

merged 3 commits into from
Mar 7, 2024

Commits on Mar 7, 2024

  1. efikeygen: move knowledge of key size and exponents up a level 

    We need to be able to generate keys other than just RSA2048 now.  As a
result, we need to have the key generation data determined outside of
generate_keys() itself.

This makes those parameters part of the generate_keys() call, and moves
the default values into efikeygen itself.

Signed-off-by: Peter Jones <[email protected]>
    @vathpela
    vathpela committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    737833e View commit details
    Browse the repository at this point in the history

  2. efikeygen: Add support for RSA3072 and RSA4096 

    This adds a "--algorithm" flag to which you can pass rsa2048, rsa3072,
and rsa4096.

Signed-off-by: Peter Jones <[email protected]>
    @vathpela
    vathpela committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    1793a67 View commit details
    Browse the repository at this point in the history

  3. efikeygen: Account for the signature size in bundle_signature() 

    In ea7a2c4, when bundling the signature, the bitstring type field
is being set manually with a hacky offset.  That offset is only valid
with specific signature types, and so with any signature of a different
size, this is just corrupting data either in the signature or after it.

This change from Egor fixes the egregious hack to manually set the type
so that it computes the location based on the signature length, rather
than hard-coding a value.

Signed-off-by: Peter Jones <[email protected]>
    @Blarse @vathpela
    Blarse authored and vathpela committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    7aa22f8 View commit details
    Browse the repository at this point in the history