Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pesign: Fix signature removal #116

Merged
merged 2 commits into from
Mar 7, 2024
Merged

pesign: Fix signature removal #116

merged 2 commits into from
Mar 7, 2024

Conversation

Blarse
Copy link
Contributor

@Blarse Blarse commented Nov 16, 2023

Closes: #115

@Blarse Blarse changed the title Produce original unsigned binary after removing signature pesign: Fix signature removal Feb 1, 2024
@Blarse Blarse marked this pull request as ready for review February 1, 2024 13:22
@Blarse
Copy link
Contributor Author

Blarse commented Feb 1, 2024

This PR makes pesign actually remove signatures. Prior this PR, pesign just copied input pe file without signatures and terminated with an error before finalizing. This led to the signature record left in the PE header.

@vathpela vathpela merged commit f1ee951 into rhboot:main Mar 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing signature does not produce the original unsigned binary
2 participants