start-ceph: do rm -rf only when path exists

start-ceph has a line to remove `rm -rf "$CEPH_CONF_PATH"/*` If someone run this script locally when he has root previllages, he could accidentally remove his `/` directory because `CEPH_CONF_PATH` will come empty and the command will become `rm -rf /*` which is like shooting yourself infinitely.. Signed-off-by: Nizamudeen A <[email protected]>
rhcs-dashboard · Nov 5, 2024 · fccae8d · fccae8d
1 parent 1438cae
commit fccae8d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/docker/ceph/ci/sanity-checks.sh b/docker/ceph/ci/sanity-checks.sh
@@ -191,7 +191,10 @@ setup_api_tests_env() {
 
     cd "$REPO_DIR"/build
 
-    rm -rf "$CEPH_CONF_PATH"/*
+    # if CEPH_CONF_PATH exists then remove that folder and everything in it
+    if [[ -d "$CEPH_CONF_PATH" ]]; then
+        rm -rf "$CEPH_CONF_PATH"/*
+    fi
     rm -f vstart_runner.log
 
     # vstart_runner uses /ceph/build cluster path.

diff --git a/docker/ceph/start-ceph.sh b/docker/ceph/start-ceph.sh
@@ -45,7 +45,10 @@ if [[ -n "${DASHBOARD_URL}" ]]; then
     exit 0
 fi
 
-rm -rf "$CEPH_CONF_PATH"/*
+# if CEPH_CONF_PATH exists then remove that folder and everything in it
+if [[ -d "$CEPH_CONF_PATH" ]]; then
+    rm -rf "$CEPH_CONF_PATH"/*
+fi
 
 cd /ceph/build
 ../src/vstart.sh ${VSTART_OPTIONS}