Update grafana version to 8.3.5 in docker-compose.yml #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aashish Sharma <[email protected]>
nizamial09
reviewed
Aug 3, 2022
| @@ -96,7 +96,7 @@ services: | |||
| - DASHBOARD_URL=${DASHBOARD_URL:-https://ceph2:11000} | |||
|
|
|||
| grafana: | |||
| image: ${GRAFANA_IMAGE:-ceph/ceph-grafana} | |||
| image: ${GRAFANA_IMAGE:-quay.io/ceph/ceph-grafana:8.3.5} | |||
There was a problem hiding this comment.
@aaSharma14 while testing this I realized that I just had to do a docker-compose pull grafana in local to pull the latest grafana image. Because ceph/ceph-grafana should pull the latest image in the repo right? And if we pin the grafana version we'll have to change it again once we push a newer version in ceph/ceph-grafana.
I don't think we need to worry about version pinning here since we are the only ones who is going to push to ceph/ceph-grafana.
The other thing is the quay.io. if we don't provide it, does the docker-compose pull the image from docker or quay?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update grafana version to 8.3.5 in docker-compose.yml
Signed-off-by: Aashish Sharma [email protected]