Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add squid branch in builds #86

Closed
wants to merge 1 commit into from

Conversation

afreen23
Copy link
Contributor

Squid branch is missing in ceph-dev builds.
This PR adds that.

Also disables google chat notification as we no longer use google chat.

@afreen23 afreen23 force-pushed the build-squid branch 6 times, most recently from 33a501b to 8aecb2f Compare October 10, 2024 18:56
- Squid branch is missing in ceph-dev builds.
- Also removes google chat notification as we no longer use google chat.
o

Signed-off-by: Afreen Misbah <[email protected]>
@afreen23
Copy link
Contributor Author

afreen23 commented Oct 10, 2024

Finally, after crazy attempts, I have come to know that "secrets" are not passed into PRs and thats why docker login failing here.
See https://stackoverflow.com/questions/78081249/github-actions-fails-to-access-secrets

Workflows triggered via pull_request_target have write permission to the target repository. They also have access to target repository secrets. The same is true for workflows triggered on pull_request from a branch in the same repository, but not from external forks. The reasoning behind the latter is that it is safe to share the repository secrets if the user creating the PR has write permission to the target repository already.

So let me raise a separate branch in the ceph-dev repo and try it.

@afreen23 afreen23 closed this Oct 10, 2024
@afreen23
Copy link
Contributor Author

Wow, it worked here #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant