-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for specialized & network disks and advanced partitioning message bar #1
base: main
Are you sure you want to change the base?
Conversation
anabot/runtime/installation/hub/partitioning/specialized_disks/__init__.py
Outdated
Show resolved
Hide resolved
anabot/runtime/installation/hub/partitioning/specialized_disks/__init__.py
Outdated
Show resolved
Hide resolved
anabot/runtime/installation/hub/partitioning/specialized_disks/__init__.py
Outdated
Show resolved
Hide resolved
anabot/runtime/installation/hub/partitioning/specialized_disks/__init__.py
Show resolved
Hide resolved
anabot/runtime/installation/hub/partitioning/specialized_disks/__init__.py
Outdated
Show resolved
Hide resolved
1e26d74
to
12ef644
Compare
Also, could you please use the full "specialized" instead of "spec". "spec" is also used as "specification". |
12ef644
to
8bdfb57
Compare
Agreed, this is probably safer. Not that such a thought didn't come to my mind as well - but I thought it would be better not to use such a long element name. |
8bdfb57
to
b477f53
Compare
I changed the behaviour of the |
Hmm, as this is fork based pull request the downstream CI was not triggered :/ |
@pholica Thanks for the suggestion, I pushed the related content in a new branch directly in rhinstaller/anabot. It looks like the CI hasn't been triggered as well again, is there anything else needed? |
No, the push should be sufficient, let's discuss this via different channels as the only last thing needed for this Pull request is to test the changes in the downstream and if that's successful, I'll merge this pull request. |
b477f53
to
22005c4
Compare
This is needed to cover RTT-4125.