Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specialized & network disks and advanced partitioning message bar #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jikortus
Copy link
Contributor

@jikortus jikortus commented Mar 4, 2022

This is needed to cover RTT-4125.

@pholica
Copy link
Contributor

pholica commented Mar 10, 2022

Also, could you please use the full "specialized" instead of "spec". "spec" is also used as "specification".

@jikortus
Copy link
Contributor Author

Also, could you please use the full "specialized" instead of "spec". "spec" is also used as "specification".

Agreed, this is probably safer. Not that such a thought didn't come to my mind as well - but I thought it would be better not to use such a long element name.

@jikortus
Copy link
Contributor Author

I changed the behaviour of the Done button check so that it only checks the done_handler result as we agreed in our discussion about the proper way to handle this. The check for Done button in the advanced & network disks subspoke is now only handled by add_specialized_disk_check.

@pholica
Copy link
Contributor

pholica commented Mar 24, 2022

Hmm, as this is fork based pull request the downstream CI was not triggered :/

@jikortus
Copy link
Contributor Author

@pholica Thanks for the suggestion, I pushed the related content in a new branch directly in rhinstaller/anabot. It looks like the CI hasn't been triggered as well again, is there anything else needed?

@pholica
Copy link
Contributor

pholica commented Mar 25, 2022

No, the push should be sufficient, let's discuss this via different channels as the only last thing needed for this Pull request is to test the changes in the downstream and if that's successful, I'll merge this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants