Skip to content

Commit

Permalink
Merge pull request #27 from rvykydal/flaky-logo-image
Browse files Browse the repository at this point in the history
tests: address pixel tests flakiness with unloaded logo image
  • Loading branch information
KKoukiou authored Nov 20, 2023
2 parents 4094b75 + ff4afef commit 502bd73
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/helpers/installer.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def open(self, step="installation-language"):
self.browser.open(f"/cockpit/@localhost/anaconda-webui/index.html#/{step}")
self.wait_current_page(step)
# Ensure that the logo is visible before proceeding as pixel tests get racy otherwise
self.browser.wait_js_cond("document.querySelector('.logo').complete")
self.browser.wait_js_cond("document.querySelector('.logo').complete && document.querySelector('.logo').naturalHeight !== 0")

def click_step_on_sidebar(self, step=None):
step = step or self.get_current_page()
Expand Down

0 comments on commit 502bd73

Please sign in to comment.