Skip to content

Commit

Permalink
webui-desktop: do not kill cockpit-ws if BROWSER dies
Browse files Browse the repository at this point in the history
In recent boot.iso we noticed firefox crashing under wayland.
This would kill also cockpit-ws, to which tests would be connecting
remotely, therefore destroying the whole test run.

Although firefox crashing is serious and will be reported, we don't have
to block the while test suite run on that, since we run tests remotely.
  • Loading branch information
KKoukiou committed Oct 22, 2024
1 parent 579a13f commit e4c9d13
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions webui-desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,12 @@ exec > >(systemd-cat -t anaconda) 2>&1
# Cleanup function
cleanup() {
set +e
if [[ "$WEBUI_REMOTE" == "1" ]]
then
echo "Warning: BROWSER died unexpectedly. Not doing further cleanup as we might be connecting remotely."
wait $WS_PID
fi

kill $WS_PID
wait $WS_PID
kill $B_PID
Expand Down

0 comments on commit e4c9d13

Please sign in to comment.