storage: show toast notification when disks selection changed #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Also change the notification type to toast for the 'no changes detected', in order to avoid moving UI elements when the notification appears. This also fixes a bug, where the 'not additional disks detected' notification appears while re-scan is in progress. Resolves: INSTALLER-3727 Resolves: INSTALLER-3742
KKoukiou
force-pushed
the
storage-disks-changed-notification
branch
from
66c7624
to
9563c3b
Compare
vojtechtrefny
approved these changes
Nov 20, 2023
rvykydal
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change the notification type to toast for the 'no changes detected', in order to avoid moving UI elements when the notification appears.
This also fixes a bug, where the 'not additional disks detected' notification appears while re-scan is in progress.
Resolves: INSTALLER-3727
Resolves: INSTALLER-3742