Skip to content

build: Introduce node_modules/ as submodule #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025

Conversation

KKoukiou
Copy link
Contributor

Build and maintain the node_modules/ as a submodule, using the tools/node-modules script as it's done in the cockpit repo.

Introduce some helper workflows around it, all copied from cockpit project.

@KKoukiou KKoukiou marked this pull request as draft March 11, 2025 09:58
@KKoukiou KKoukiou force-pushed the node-cache branch 8 times, most recently from 9bd2c63 to 71105df Compare May 15, 2025 07:24
@KKoukiou KKoukiou marked this pull request as ready for review May 15, 2025 07:30
@KKoukiou KKoukiou requested a review from jelly May 15, 2025 07:48
Copy link
Contributor

@jelly jelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I would bump the container to ubuntu-latest

KKoukiou added 3 commits May 15, 2025 10:46
Build and maintain the node_modules/ as a submodule, using the
tools/node-modules script as it's done in the cockpit repo.

Introduce some helper workflows around it, all copied from cockpit
project.
@KKoukiou KKoukiou merged commit 528e9ba into rhinstaller:main May 15, 2025
6 checks passed
@KKoukiou KKoukiou deleted the node-cache branch May 15, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants