storage: avoid rendering wizard pages while Cockpit Storage is active #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
force-pushed
the
show-storage-convervative
branch
2 times, most recently
from
bb6fabb to
7951d55
Compare
Rendering wizard pages in the background can trigger API calls to devices that may no longer exist, leading to errors. We currently work around this by handling and silencing these errors [1] as a hotfix for Fedora 42, due to limited time to implement a proper fix. This change takes first steps to a more robust approach by preventing the rendering of wizard pages entirely while cockpit-storage mode is active, avoiding invalid device accesses altogether. [1] rhinstaller@53f2ff
KKoukiou
force-pushed
the
show-storage-convervative
branch
from
7951d55 to
45ae6e6
Compare
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @KKoukiou - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -71,7 +71,6 @@ const InstallationScenarioSelector = ({ | |||
| idPrefix, | |||
| isFormDisabled, | |||
| setIsFormValid, | |||
| showStorage, | |||
There was a problem hiding this comment.
question (bug_risk): Removed showStorage guard; ensure side effects are controlled
Without showStorage’s guard, ensure useEffect dispatches don’t fire unexpectedly when cockpit storage mode toggles.
rvykydal
approved these changes
May 15, 2025
Removing the workaround needs more work. I was experimenting in #754 for that, I might get back to that next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering wizard pages in the background can trigger API calls to devices that may no longer exist, leading to errors.
We currently work around this by handling and silencing these errors [1] as a hotfix for Fedora 42, due to limited time to implement a proper fix.
This change takes first steps to a more robust approach by preventing the rendering of wizard pages entirely while cockpit-storage mode is active, avoiding invalid device accesses altogether.
[1] 53f2ff