infra: ensure template alignment across branches #5582
Conversation
github-actions
bot
added
infrastructure
|
This will run only on branches != master. Success example: KKoukiou#4 |
KKoukiou
force-pushed
the
infra-templates-master
branch
from
95b2ce4 to
14d4087
Compare
There was a problem hiding this comment.
Looks good to me. However, this will start failing on PRs which are not related to the templates files. That could be pretty confusing because all the failures on PR should be related to PR.
I like this idea, but I would change to run this once a day from master branch instead of on PRs.
Moving that to run on cron schedule from master, will not prevent us to merge template inconsistencies on branches. I think it's ok to block merging PRs on a repository that's not 'correct'. Syncing some template changes should be after all not be that hard. |
|
However, you will also put this "failed" burden on external contributors or people who are solving blocker bugs. I have a bad feeling that output of this would be that we will start merging Red PRs because "it's not caused by this PR". |
KKoukiou
force-pushed
the
infra-templates-master
branch
3 times, most recently
from
c8a9d87 to
d8d8019
Compare
KKoukiou
force-pushed
the
infra-templates-master
branch
from
d8d8019 to
7ec4263
Compare
There was a problem hiding this comment.
@jkonecny12 ok now it checks only affected template files from a PR.
This commit implements a vital check to ensure consistent template alignment between the master branch and other branches. It enforces that template files on the master branch remain the definitive source of truth. This decreases maintainance effort by having less files. This check will get only activated on PRs that touch template files, in order to not block unrelated work on the branches.
KKoukiou
force-pushed
the
infra-templates-master
branch
from
7ec4263 to
cc17b48
Compare
|
Thanks for another improvement! |
|
/kickstart-test --waive infra only |
This commit implements a vital check to ensure consistent template alignment between the master branch and other branches. It enforces that template files on the master branch remain the definitive source of truth.
This decreases maintainance effort by having less files.