-
Notifications
You must be signed in to change notification settings - Fork 36
Add centos10 platform #1452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add centos10 platform #1452
Conversation
/test-os-variants |
/test-tmt |
3750181
to
9d01424
Compare
/test-os-variants |
https://github.com/rhinstaller/kickstart-tests/actions/runs/16440809016 Will run more decent test. |
/test-os-variants --testtype smoke |
/test-tmt |
The test failures are expected - on rhel10 the test is disabled, on daily-iso there is a known issue with updated version of initial setup not being used. |
Resolves: INSTALLER-4014
Resolves: INSTALLER-4014
Resolves: INSTALLER-4014
Use skip-on-centos-10 (instead of skip-on-centos10) preferring local consistency (with other tags eg skip-on-rhel-10). Making the tags consistent with platform name (centos10, rhel10 -> skip-on-centos10, skip-on-rhel10, skip-on-rhel...) would be a follow-up patch. Resolves: INSTALLER-4014
Initially use current skip-on-rhel and skip-on-rhel-10. Later review if they really apply to centos10 by running all tests in a daily run. Resolves: INSTALLER-4014
Resolves: INSTALLER-4014
The values for rhel10 were used when adding centos10 platform. This is a temporary setting to check in a daily run if the values hold for centos10. Resolves: INSTALLER-4014
9d01424
to
6ddaf6e
Compare
/test-os-variants --testtype smoke |
/test-tmt |
1 similar comment
/test-tmt |
The test failures are expected - on rhel10 the test is disabled, on daily-iso there is a known issue with updated version of initial setup not being used. |
@@ -0,0 +1,3 @@ | |||
# Unified ISO for CentOS 10 served on http server | |||
# BaseOS and AppStream repositories should be loaded automatically from the unified repo | |||
url CENTOS10_UNIFIED_REPO_URL_GOES_HERE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This placeholder will be replaced in some further update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is (similar as for other platforms) included in unified.sh test which is manual, so I guess it is up to the person who runs the test manually to find (or create) the unified iso and replace the placeholder.
@@ -0,0 +1,3 @@ | |||
# Create a variable in the pre/post section with link to a CentOS-Stream-10 unified ISO | |||
# The curl tool will download this ISO and it will be processed later in the section. | |||
ISO_LOCATION=<link to a unified ISO> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This placeholder will be replaced in some further update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar as #1452 (comment) but for unified-harddrive test (also manual).
Resolves: INSTALLER-4014
The PR updates also daily tests workflow to run centos10 tests. It contains also commit that would run all the tests for centos10 platform, so we can review the initial disablement of tests on centos10 which is based on tests disabled for rhel10.
NOTE: potential fragments deduplication / inheritence with symlinks were already considered a while ago in #1153. I think that (for the current / expected number and structure of platforms) it is still better (from the maintenance and readability POV) to have flat structure without indirection. As for possible suggestions for modification of fragments structure, I'd resolve it out of scope of this PR so we don't block running tests of tests on centos10 (and eln as follow-up). And so we move in steps.