fix: shellcheck wrong curl #510
Conversation
marioferh
requested review from
jan--f and
danielmellado
and removed request for
a team
Signed-off-by: Mario Fernandez <[email protected]>
marioferh
force-pushed
the
fix_shellcheck_curl
branch
from
2098455 to
c2a9c8a
Compare
| @@ -188,8 +188,8 @@ $(SHELLCHECK) shellcheck: $(TOOLS_DIR) | |||
| set -ex ;\ | |||
| [[ -f $(SHELLCHECK) ]] && exit 0 ;\ | |||
| cd $$(mktemp -d) ;\ | |||
| OS=$(shell go env GOOS) && ARCH=$(shell go env GOARCH) && \ | |||
| curl -sSLo shellcheck-stable.tar.xz "https://github.com/koalaman/shellcheck/releases/download/stable/shellcheck-stable.$$(OS).$$(ARCH).tar.xz";\ | |||
| OS=$(shell go env GOOS) && ARCH=$(shell uname -m) && \ | |||
There was a problem hiding this comment.
I don't think that we need to change the way the ARCH var is filled?
There was a problem hiding this comment.
output of arch is:
ARCH=amd64
then:
https://github.com/koalaman/shellcheck/releases/download/stable/shellcheck-stable.limux.amd64.tar.xz
and that's 404
Correct one is:
https://github.com/koalaman/shellcheck/releases/download/stable/shellcheck-stable.linux.x86_64.tar.xz
There was a problem hiding this comment.
before was: db0b62f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marioferh, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Action publish-olm-candidate https://github.com/rhobs/observability-operator/actions/runs/9462114451/job/26065129373 is failing due an error in shellheck curl.