chore: Use condition from the meta package and clarify the status #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
requested review from
danielmellado and
jgbernalp
and removed request for
a team
jan--f
reviewed
Jul 3, 2025
| // +optional | ||
| Tempo string `json:"tempo,omitempty"` | ||
|
|
||
| // Conditions provide status information about the instance. | ||
| // +listType=atomic | ||
| // +optional | ||
| Conditions []StatusConditions `json:"conditions,omitempty"` | ||
| Conditions []metav1.Condition `json:"conditions,omitempty"` | ||
| } | ||
|
|
||
| type StatusConditions struct { |
There was a problem hiding this comment.
The StatusCondition field can be deleted now I suppose?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alanconway, pavolloffay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
pavolloffay
force-pushed
the
cluster-observability
branch
from
fd44f02 to
edd13e0
Compare
pavolloffay
force-pushed
the
cluster-observability-review-comments
branch
from
ea38a65 to
186aba4
Compare
pavolloffay
force-pushed
the
cluster-observability-review-comments
branch
from
186aba4 to
1084f14
Compare
Signed-off-by: Pavol Loffay <[email protected]>
pavolloffay
force-pushed
the
cluster-observability-review-comments
branch
from
1084f14 to
4b6bfa0
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.