Skip to content

feat: new Go module for the API #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Jul 7, 2025

This is a next step for the https://issues.redhat.com/browse/COO-862.

@tremes tremes requested a review from a team as a code owner July 7, 2025 08:06
@tremes tremes requested review from falox and zhuje and removed request for a team July 7, 2025 08:06
@openshift-ci openshift-ci bot requested a review from danielmellado July 7, 2025 08:06
@tremes
Copy link
Contributor Author

tremes commented Jul 8, 2025

The current CI failures are related to the RUN go mod download step in the Dockerfile. It doesn't work with the Go mod replace. We can temporarily comment the step in the Dockerfile or accept the failures since this will require a follow-up PR for removing the replace anyway.

@jan--f
Copy link
Collaborator

jan--f commented Jul 8, 2025

The current CI failures are related to the RUN go mod download step in the Dockerfile. It doesn't work with the Go mod replace. We can temporarily comment the step in the Dockerfile or accept the failures since this will require a follow-up PR for removing the replace anyway.

Can't we fix this by adding a temporary cp line?

 COPY pkg/apis/go.mod pkg/apis/go.mod

@jan--f
Copy link
Collaborator

jan--f commented Jul 8, 2025

/lgtm

@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Jul 8, 2025
@jan--f
Copy link
Collaborator

jan--f commented Jul 8, 2025

Sorry I think we need the same in https://github.com/rhobs/observability-operator/blob/main/build/Dockerfile

@jan--f
Copy link
Collaborator

jan--f commented Jul 8, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 8, 2025
@tremes
Copy link
Contributor Author

tremes commented Jul 9, 2025

/test observability-operator-e2e

@jan--f
Copy link
Collaborator

jan--f commented Jul 9, 2025

/approve

Copy link

openshift-ci bot commented Jul 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 32736be into rhobs:main Jul 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants