Settings file generation #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll have to rebase after #246 is merged, this before I can review it. |
done |
naxvog
force-pushed
the
settings_file
branch
from
bf7ea56
to
860759e
Compare
|
@naxvog: Can you revert touching the |
|
Well if I decouple the settings file generation there would not be any functionality or benefit left. The whole thing exists to allow for |
|
Closing this for now. Open to pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am proposing a settings file located at
WP_CONTENT_DIR . '/redis_object_cache/settings.phpdefining the location of the plugin (and potentially a basic configuration as per #173).This change makes it possible to de-clutter the drop-in by splitting the cache function and class definitions into their respective files in the includes directory.