Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invent cache salt #559

Closed
wants to merge 1 commit into from
Closed

Conversation

edneville
Copy link

If there are multiple sites using the same redis server then invent a salt that gives uniqueness for each site to avoid collision.

If there are multiple sites using the same redis server then invent a
salt that gives uniqueness for each site to avoid collision.

Signed-off-by: ed neville <[email protected]>
@tillkruss
Copy link
Member

This will suddenly give all sites a prefix and jack up their Redis server size. Feel free to extend the documentation, (or admin gui) instead.

@tillkruss tillkruss closed this Dec 12, 2024
@edneville
Copy link
Author

@tillkruss, thanks for reviewing. Isn't it better to have a prefix to avoid collision? Would it be acceptable to then to say in the docs to define WP_REDIS_PREFIX with an empty string if that's not desired? Ideally I'd like to provide some default protection to avoid two installs on the same infrastructure from colliding.

@tillkruss
Copy link
Member

tillkruss commented Dec 12, 2024

Yeah, feel free to document it, or even add it to the admin UI.

Remember that the DB prefix isn't unique across multiple installations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants