Skip to content

Conversation

richtabor
Copy link
Owner

@richtabor richtabor commented Nov 22, 2024

The only noticeable change is that the archive template will now render the title of the archive (the tag, category, etc) and the description (if there is one added to the tag, category, etc).

CleanShot 2024-11-22 at 13 33 50

Feedback reported:

  1. The site title is incorrectly marked as an H1, which results in
    multiple H1s on pages and posts.
    <h1 class="wp-block-site-title" data-element-id="headingsMap-0-0"><a href="https://reverent-cod-7b24ca.instawp.xyz/" target="_self" rel="home ">[wp-a11y-theme-test.instawp.xyz](http://wp-a11y-theme-test.instawp.xyz/)</a></h1>
    This should be marked as a paragraph rather than an H1 so that the post
    title is the only H1 on the page.
  1. The "You may also enjoy..." text on single posts is not marked as a
    heading, though it should be and the blog posts below it have the
    incorrect heading level set. This text should be an H2 instead of a paragraph and the blog posts below
    it should be H3s instead of H2s.
  1. The H1 on tag and category archive does not match the purpose of the
    page. It stays as the hard-coded "Hi, I’m Rich Tabor" text. This should output the title of the category or tag.
  1. Color contrast failures:
    The color #7A7A7A on a white background has a contrast ratio of 4.3:1 and
    fails contrast checks.

@richtabor richtabor added the enhancement New feature or request label Nov 22, 2024
@richtabor richtabor self-assigned this Nov 22, 2024
@richtabor richtabor merged commit c0bddd8 into main Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant