Skip to content

Conversation

yne
Copy link

@yne yne commented Oct 15, 2019

While writing the documentation about the deezer HTML5 player, I found a cute typo that led me to this PR.

@yne
Copy link
Author

yne commented Feb 28, 2020

@ricmoo I know this is not a relly important PR so I can close it if you want

@Ruffio
Copy link

Ruffio commented Apr 3, 2020

#95 covers more typos and should be merged :-)

@yne
Copy link
Author

yne commented Apr 4, 2020

Good to know, I'll close this MR then.

@yne yne closed this Apr 4, 2020
@ricmoo
Copy link
Owner

ricmoo commented Apr 4, 2020

Oh! I’ll get to this. You can leave it open. I’ve been busy with v5 of ethers, which will hopefully be out soon (tm). :)

@yne
Copy link
Author

yne commented Apr 4, 2020

The #95 is way more complet that this one, so it's fine :)

I fixed the typo just to see how often the Dezzer dev team upgrade they node dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants