Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tsf): hide IME mode icon #1515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(tsf): hide IME mode icon #1515

wants to merge 1 commit into from
+16 −2

Conversation

wzv5
Copy link
Contributor

@wzv5 wzv5 commented Feb 22, 2025

lotem
lotem reviewed Feb 24, 2025
View reviewed changes
WeaselSetup/WeaselSetup.cpp
@@ -186,6 +186,16 @@ static int Run(LPTSTR lpCmdLine) {
return SetRegKeyValue(HKEY_CURRENT_USER, L"Software\\Rime\\weasel",
L"ToggleImeOnOpenClose", L"no", REG_SZ);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/toggleime, /toggleascii, /hidemodeicon, /showmodeicon

這些是否方便寫在配置文件 weasel.yaml 裏？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我也是看之前有这样的先例，想着小众需求就也这样做吧，之前已经跟 @fxliang 交流过了。怎么说，要改么？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不知道這個地方讀寫配置方不方便。我擔心註冊表開關越加越多，不統一了。

@lotem lotem requested a review from fxliang February 24, 2025 04:21
@wzv5
Copy link
Contributor Author

wzv5 commented Feb 25, 2025

暂时没空处理这个pr，ipc部分还挺复杂的，一时半会不好解决。

如果谁有需要，可以使用我之前做的修改补丁，dUP2 制作的，包含源码。
补丁解压到 weasel 安装目录中，如 C:\Program Files\Rime\weasel-0.16.3，然后运行补丁，会自动修改 weasel.dll 和 weaselx64.dll。
然后手动把修改后的 weasel.dll 复制到 C:\Windows\SysWOW64 并替换同名文件。
把 weaselx64.dll 先复制到桌面等临时位置，改名为 weasel.dll，再复制到 C:\Windows\System32 并替换同名文件。
如果无法替换，可以先把系统默认输入法改为微软拼音，重启后再替换，替换完再把默认输入法改回来。

小狼毫去输入法状态图标补丁.zip

Image

@lotem
Copy link
Member

lotem commented Feb 25, 2025

原來是這樣。

那我接受不常用的前端功能暫時不受 YAML 配置控制。

我記得後端向前端傳了 UI style 的信息。以後找機會統一加上吧。

@fxliang
Copy link
Contributor

fxliang commented Feb 25, 2025

可以加到style里传递过去，然后在style更新的时候重新_UninitLanguageBar然后_InitLanguageBar一下，毕竟_InitLanguageBar里是可以调用_cand->style()的，IPC过程实现可以不用动也行

其实似乎还行，复杂度

只是这样操作我问题觉得有点奇怪怕空指针之类的东西出现，感觉要再围观一下这样

@wzv5
Copy link
Contributor Author

wzv5 commented Feb 25, 2025

这也不算是style，跟随style传递总感觉不太好。
而且ipc读和写是分离的，以至于一时之间很难看出配置是如何传递的，不太敢直接下手改。
最近有点忙，就没打算深入研究ipc了。

lotem
lotem approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@lotem lotem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不好改成YAML就先這樣。

可能要在文檔裏說明這些參數。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lotem lotem lotem approved these changes

@fxliang fxliang Awaiting requested review from fxliang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wzv5 @lotem @fxliang