Skip to content

ci: fix ci actions caused by runner updating #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 17, 2025
Merged

ci: fix ci actions caused by runner updating #1645

merged 10 commits into from
Jul 17, 2025

Conversation

fxliang
Copy link
Contributor

@fxliang fxliang commented Jul 4, 2025 •
edited
Loading

  • fix lint caused by runner updating
  • workaround to pass ci by setting sdk version

lotem
lotem reviewed Jul 5, 2025
View reviewed changes
.github/workflows/commit-ci.yml
@@ -84,8 +88,9 @@ jobs:
./install_boost.bat
./build.bat boost arm64

- name: Add msbuild to PATH
uses: microsoft/setup-msbuild@v2
- uses: ilammy/msvc-dev-cmd@v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這是何方神聖？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外一个设置msvc环境的方法，可以定义SDK版本

要设置sdk版本是因为，vs2022默认用的最新的sdk在跑arm 32位的时候报错，已丢掉了支持，查原来微软的方案没有办法设置

build.bat Outdated
if errorlevel 1 goto error
copy arm64x_wrapper\weaselARM64X.ime output
if errorlevel 1 goto error
rem copy arm64x_wrapper\weaselARM64X.dll output
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這腳本不太合理啊。
命令行參數 arm64 都不給了，理應不執行這兩項操作~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這腳本不太合理啊。 命令行參數 arm64 都不給了，理應不執行這兩項操作~

您再细看下，目前的状态是不构建ARM64EC的转发器dll，但是ARM64/ARM都还是可以用的。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

天，這裏面的道道還怪多叻。

@lotem
Copy link
Member

lotem commented Jul 5, 2025

我就關心：這此升級之後，誰不能用了？

@fxliang
Copy link
Contributor Author

fxliang commented Jul 5, 2025

@driver1998 旧的编译环境已经在ci中没有了支持，麻烦看看ARM相关的方案是不是可以

@fxliang
Copy link
Contributor Author

fxliang commented Jul 5, 2025

我就關心：這此升級之後，誰不能用了？

call人来看了，X86/X64肯定没问题，ARM/ARM64的我没有设备没办法试，ARM64EC的我不懂怎么解，粗暴先禁了

@driver1998
Copy link
Contributor

Actions删掉了ARM32的SDK? 如果是的话将ARM32禁了也不是不行，Win11已经将ARM32支持全部删除，原本需要这东西的也不多。
ARM64EC我看看怎么修

@fxliang
Copy link
Contributor Author

fxliang commented Jul 5, 2025

Actions删掉了ARM32的SDK? 如果是的话将ARM32禁了也不是不行，Win11已经将ARM32支持全部删除，原本需要这东西的也不多。 ARM64EC我看看怎么修

是vs2022的默认新版Windows sdk已经扔了ARM32，目前这个pr我是试设置用旧的Windows sdk来编译，但是ARM64EC不懂怎么修要你看看了

@lotem
Copy link
Member

lotem commented Jul 6, 2025

Actions删掉了ARM32的SDK? 如果是的话将ARM32禁了也不是不行，Win11已经将ARM32支持全部删除，原本需要这东西的也不多。
ARM64EC我看看怎么修

有勞了。微軟不支持的，咱也可以跟進。

@driver1998
Copy link
Contributor

driver1998 commented Jul 6, 2025 •
edited
Loading

ARM64EC已经修复，在https://github.com/driver1998/weasel/tree/master ，拉一下就行。
指定SDK版本的方式好像还是有点问题 已修复

@driver1998
Copy link
Contributor

还需要等什么吗？如果要ARM机器测试安装包的话我这周末看一下

@fxliang fxliang changed the title Workaround ci: fix ci actions caused by runner updating Jul 17, 2025
@fxliang fxliang merged commit 35cd09c into rime:master Jul 17, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lotem lotem lotem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fxliang @lotem @driver1998