-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre commit #221
Pre commit #221
Conversation
Codecov Report
@@ Coverage Diff @@
## release3 #221 +/- ##
============================================
- Coverage 53.47% 52.70% -0.77%
============================================
Files 93 93
Lines 12647 12884 +237
============================================
+ Hits 6763 6791 +28
- Misses 5884 6093 +209
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nicer and correctre env definitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a huge formatting change, but I think it is very good :)
What about this hook:
|
|
We first need to fix the code. But this will be a second PR as mentioned in issue #227 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like lots of good cleanup! My code is still running.
Description
This PR adds
pre-commit
to the repo. This will help to keep the code clean and up to standartsTodos
TODOs moved to next PR. See Issue #227
Status