Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre commit #221

Merged
merged 12 commits into from
Feb 25, 2022
Merged

Pre commit #221

merged 12 commits into from
Feb 25, 2022

Conversation

MTLehner
Copy link
Collaborator

@MTLehner MTLehner commented Feb 23, 2022

Description

This PR adds pre-commit to the repo. This will help to keep the code clean and up to standarts

Todos

TODOs moved to next PR. See Issue #227

Status

  • Ready to go

@MTLehner MTLehner self-assigned this Feb 23, 2022
@MTLehner MTLehner added enhancement New feature or request feature help wanted Extra attention is needed labels Feb 23, 2022
@MTLehner MTLehner linked an issue Feb 23, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #221 (e07c23e) into release3 (bb9b66e) will decrease coverage by 0.76%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release3     #221      +/-   ##
============================================
- Coverage     53.47%   52.70%   -0.77%     
============================================
  Files            93       93              
  Lines         12647    12884     +237     
============================================
+ Hits           6763     6791      +28     
- Misses         5884     6093     +209     
Flag Coverage Δ
unittests 52.70% <ø> (-0.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pygromos/__init__.py 100.00% <ø> (ø)
pygromos/analysis/coordinate_analysis.py 29.41% <ø> (ø)
pygromos/analysis/energy_analysis.py 50.00% <ø> (ø)
pygromos/analysis/error_estimate.py 100.00% <ø> (ø)
pygromos/analysis/free_energy_calculation.py 66.97% <ø> (-0.16%) ⬇️
pygromos/data/__init__.py 100.00% <ø> (ø)
pygromos/data/ene_ana_libs/__init__.py 0.00% <ø> (ø)
pygromos/data/ff/Gromos2016H66/__init__.py 100.00% <ø> (ø)
pygromos/data/ff/Gromos54A7/__init__.py 100.00% <ø> (ø)
pygromos/data/ff/MixHexGromos54A7/__init__.py 0.00% <ø> (ø)
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f165d6...e07c23e. Read the comment docs.

Copy link
Collaborator

@RiesBen RiesBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge formatting change, but I think it is very good :)

@MTLehner MTLehner mentioned this pull request Feb 25, 2022
8 tasks
@pultar
Copy link
Collaborator

pultar commented Feb 25, 2022

What about this hook:

  - repo: https://github.com/myint/autoflake
    rev: v1.4
    hooks:
      - id: autoflake
        name: Removes unused variables
        args:
          - --in-place
          - --remove-all-unused-imports
          - --expand-star-imports
          - --ignore-init-module-imports

@MTLehner
Copy link
Collaborator Author

Does not work right now. All import related formatting are destroying the code due to files like _all_blocks

@MTLehner
Copy link
Collaborator Author

Does not work right now. All import related formatting are destroying the code due to files like _all_blocks

We first need to fix the code. But this will be a second PR as mentioned in issue #227

Copy link
Collaborator

@pultar pultar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like lots of good cleanup! My code is still running.

@MTLehner MTLehner merged commit d7fa71a into release3 Feb 25, 2022
@MTLehner MTLehner deleted the pre-commit branch March 31, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit hooks
3 participants