Fixes Issue #1285 (Icons out of sync on Tokens page)#1301
Open
manavukani wants to merge 1 commit intoripple:mainfrom
Open
Fixes Issue #1285 (Icons out of sync on Tokens page)#1301manavukani wants to merge 1 commit intoripple:mainfrom
manavukani wants to merge 1 commit intoripple:mainfrom
Conversation
manavukani
changed the title
manavukani
changed the title
Patel-Raj11
approved these changes
Mar 23, 2026
Contributor
Patel-Raj11
left a comment
Patel-Raj11
left a comment
There was a problem hiding this comment.
Thanks for this contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Add a unique key prop to elements in the Tokens table to fix icon mismatches after re-sorting.
Context of Change
Bug: On the Tokens page, when filtering by a category (eg: Stablecoin) and then sorting by market cap multiple times, tokens display incorrect icons. For example, RLUSD would have the highest market cap but show another token's icon.
Root cause: The elements rendered via
tokens.map(renderToken)had nokeyprop. Adding a key ofcurrency.issuer_account(unique per token) ensures React correctly tracks each row for sorting.Type of Change
Codebase Modernization
Before / After
Test Plan