Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speicfy length fields should initialized to zero if fails to detect t… #95

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Speicfy length fields should initialized to zero if fails to detect t… #95

wants to merge 1 commit into from

Conversation

kito-cheng
Copy link
Collaborator

…he features

@kito-cheng
Copy link
Collaborator Author

cc @BeMg @topperc @lenary @jrtc27 @preames

topperc
topperc reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jrtc27
jrtc27 reviewed Nov 7, 2024
View reviewed changes
src/c-api.adoc Outdated Show resolved Hide resolved
kito-cheng added a commit to kito-cheng/llvm-project that referenced this pull request Nov 8, 2024
@kito-cheng
[compiler-rt][RISCV] Initialize length only when __init_riscv_feature…
8f87718 
…_bits success

That could give us a simple way to detect `__init_riscv_feature_bits`
got fail.

See also riscv-non-isa/riscv-c-api-doc#95
@kito-cheng kito-cheng mentioned this pull request Nov 8, 2024
Open
@kito-cheng
Copy link
Collaborator Author

GCC: https://github.com/gcc-mirror/gcc/blob/master/libgcc/config/riscv/feature_bits.c#L384
LLVM: llvm/llvm-project#115449

@kito-cheng
Copy link
Collaborator Author

@cmuellner could you help me on this, approve and merge, I can't do that since I can't self approve :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topperc topperc topperc left review comments

@jrtc27 jrtc27 jrtc27 left review comments

@lenary lenary lenary approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kito-cheng @lenary @jrtc27 @topperc