-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard Fixed-length Vector Calling Convention Variant #418
Open
kito-cheng
wants to merge
11
commits into
master
Choose a base branch
from
fixed-length-vector-cc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9453d42
Standard Fixed-length Vector Calling Convention Variant
kito-cheng 2df47cd
Minor revision
kito-cheng 4da348a
Minor revision
kito-cheng 1c19031
Apply suggestions from code review
kito-cheng 4902cef
Name Mangling for Standard Calling Convention Variant
kito-cheng 76c1816
Name mangling for standard fixed-length vector calling convention
kito-cheng 2140aa9
Tweak wording per Luke's suggesion
kito-cheng c26a99b
Minor tweak
kito-cheng 7dd1c9e
More descprtion for ABI_VLEN
kito-cheng 11b4776
Add note to vector type with unsupported element type
kito-cheng 7e9d68c
Add rule for non-power-of-2 vector
kito-cheng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just want to double check, I wasn't concerned about the wording but it seemed to me like it should be
vec_size <= ABI_VLEN
and notvec_size < ABI_VLEN
. Unless that was intentional?