Improvement #58
Merged
Improvement #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ley Foon Tan <[email protected]>
pathakraul
reviewed
Sep 7, 2024
src/srvgrp-performance.adoc
Outdated
| @@ -824,7 +824,7 @@ specific performance domain and performance service. | |||
| ! `DOMAIN_ID` is invalid. | |||
|
|
|||
| ! RPMI_ERR_NOT_SUPPORTED | |||
| ! Fast-channel not implemented. | |||
| ! Fast-channel not is implemented. | |||
There was a problem hiding this comment.
Fast-channel is not implemented, previous was also alright
pathakraul
reviewed
Sep 7, 2024
src/transport.adoc
Outdated
| a RISC-V privilege level a application processors and a platform | ||
| microcontroller. A application processors can have multiple RPMI transport | ||
| An RPMI transport instance provides bi-directional communication channels | ||
| between a RISC-V privilege-level application processor and a platform |
There was a problem hiding this comment.
between a RISC-V privilege-level of a application processor
pathakraul
reviewed
Sep 7, 2024
src/transport.adoc
Outdated
| microcontroller. A application processors can have multiple RPMI transport | ||
| An RPMI transport instance provides bi-directional communication channels | ||
| between a RISC-V privilege-level application processor and a platform | ||
| microcontroller. An application processors can have multiple RPMI transport |
There was a problem hiding this comment.
An application processor
pathakraul
reviewed
Sep 7, 2024
src/transport.adoc
Outdated
| Fast channels are shared memory based transport required for use cases | ||
| that require lower latency and faster processing of commands. A Fast channel | ||
| === Fast-channels | ||
| Fast-channels are shared memory based transport required for use cases |
There was a problem hiding this comment.
After reading this again, i think we should remove the word "transport" from this. May lead to more questions since this is not a RPMI transport as per RPMI. We can write something like-
"Fast-channels are shared memory based channel per application processor required for use cases .... ....."
added 10 commits
September 8, 2024 01:02
Signed-off-by: Ley Foon Tan <[email protected]>
Signed-off-by: Ley Foon Tan <[email protected]>
Signed-off-by: Ley Foon Tan <[email protected]>
Signed-off-by: Ley Foon Tan <[email protected]>
Signed-off-by: Ley Foon Tan <[email protected]>
- Fix EventID to 1 byte - Fix typo and grammar - Update description for RPMI_ERR_DENIED Signed-off-by: Ley Foon Tan <[email protected]>
Signed-off-by: Ley Foon Tan <[email protected]>
- Update description for RPMI_ERR_DENIED - Remove RPMI_ERR_DENIED error for DPWR_GET_STATE. Signed-off-by: Ley Foon Tan <[email protected]>
Signed-off-by: Ley Foon Tan <[email protected]>
Event ID is only one byte. Signed-off-by: Ley Foon Tan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.