-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor extensions: Add 'XTheadVdot' T-Head vendor extensions #27
base: main
Are you sure you want to change the base?
Conversation
This patch defines the T-Head vendor extensions (XTheadVdot), which is documented here: https://github.com/T-head-Semi/thead-extension-spec
@@ -318,6 +318,7 @@ T-Head | XTheadMac | 2.0.0 | [T-Head ISA extension specification | |||
T-Head | XTheadMemPair | 2.0.0 | [T-Head ISA extension specification](https://github.com/T-head-Semi/thead-extension-spec/releases/download/2.0.0/xthead-2022-09-05-2.0.0.pdf) | |||
T-Head | XTheadMemIdx | 2.0.0 | [T-Head ISA extension specification](https://github.com/T-head-Semi/thead-extension-spec/releases/download/2.0.0/xthead-2022-09-05-2.0.0.pdf) | |||
T-Head | XTheadSync | 2.0.0 | [T-Head ISA extension specification](https://github.com/T-head-Semi/thead-extension-spec/releases/download/2.0.0/xthead-2022-09-05-2.0.0.pdf) | |||
T-Head | XTheadVdot | 2.2.0 | [T-Head ISA extension specification](https://github.com/T-head-Semi/thead-extension-spec/releases/download/2.2.0/xthead-2022-12-04-2.2.0.pdf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really mind the version scheme for vendor extension, but 2.2 seems like spec version rather than extension version, and I don't see individual extension version for other T-Head extensions, does it means all other T-Head extensions also bump to 2.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kito-cheng From my personal opinion, we should set version of all T-Head ISAs as v1.0, and have individual extension version.
here I copy from @cmuellner's scheme just only, maybe @cmuellner can clarify this, he is our drafter of open-source version scheme :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version listed here is the version of the document in which the extension is the first time documented.
Since the extensions are stable (in the sense of being implemented in hardware, not in the weaker RVI sense), their version is irrelevant (similar to the version of ratified standard extensions).
I chose the document version to avoid confusion with a "1.0" version that does not match the referenced document. But I don't mind if we switch to "1.0" for all extensions.
For me, it is also ok to change all links to the latest spec version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table was updated in #28.
So once this PR is updated, this can get merged.
This patch defines the T-Head vendor extensions (XTheadVdot), which is documented here:
https://github.com/T-head-Semi/thead-extension-spec