Add large code model #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Tsung-Chun Lin <[email protected]>
|
This looks good in general. When double-checking with the implementations, I saw that LLVM does not create |
|
@asb and @kito-cheng: any objections to merging this? It looks like this is needed for llvm/llvm-project#107817 |
|
In parallel I'd added the define to riscv-c-api-doc in riscv-non-isa/riscv-c-api-doc#86 This listing of defines comes from when this repo was little more than my personal notes on what GCC does and Clang should probably do to follow suit. Now that we have the preprocessor defines listed authoritatively in riscv-c-api-doc I think it makes sense to remove them from this document, which #61 does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.