Skip to content

Conversation

dcz-self
Copy link
Contributor

The & to *mut conversion failed the build.

Fixes #58

This follows advice to eliminate the & completely: #59 (comment) . Instead, there's only a conversion from *const to *mut.

The & to *mut conversion failed the build.

Fixes riscv-rust#58

This follows advice to eliminate the & completely: riscv-rust#59 (comment) .
Instead, there's only a conversion from *const to *mut.
Copy link
Member

@Disasm Disasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Disasm
Copy link
Member

Disasm commented Aug 27, 2025

CI is broken, but I fixed it in another PR and verified that this PR builds as expected.

@Disasm Disasm merged commit d6c9567 into riscv-rust:master Aug 27, 2025
0 of 4 checks passed
@dcz-self
Copy link
Contributor Author

Thank you for merging this.
Please let me know if there's anything I can do to help. I realize that maintenance takes a lot of time so I'd like to take a more active role than just to wait for a new release :P

@Disasm
Copy link
Member

Disasm commented Aug 27, 2025

You can prepare the release instead of waiting for it :) You can also help with testing different PRs, and create new ones (I hope @rmsyn or someone from the RISC-V Team will be able to help with reviewing those).

@dcz-self
Copy link
Contributor Author

Is there anything I need to know before the release? Bump versions numbers?
I'd like to include the hal 1.0 update, but I'm not sure if I should just merge it locally as part of the release MR, or through the Github UI.

@Disasm
Copy link
Member

Disasm commented Aug 27, 2025

I suppose the release checklist is something like this:

  • check changes since the last release to decide whether the next release is a patch or a minor release
  • bump version numbers
  • update CHANGELOG.md

The hal 1.0 update needs to be reviewed and tested I guess, and merge conflicts resolved.

@dcz-self
Copy link
Contributor Author

I'll do that. The hal update may take me longer, because I just learned of an incoming deadline.

@rmsyn
Copy link
Contributor

rmsyn commented Aug 28, 2025

I hope @rmsyn or someone from the RISC-V Team will be able to help with reviewing those

Definitely! Feel free to ping me in any PR/issue you would like reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure on new toolchain

3 participants